Oh Master - please teach me the diff between a circuit & schematic diagram?!!
[ Actually, the way I see it, a circuit diagram shows the electronic path and all components and switching etc.
A wiring diagram is the "physical" depiction using "real" components etc - eg, the12volt's relay pics are wiring diagrams whereas I tend to post "circuit" diagrams.
A schematic can be anything in between (as per many of the the12volt's "circuit" pics) or involve simplified or functional "blocks".
Schematics are often simplified overviews to make the overall circuit's workings to be easier to understand.
(So, if a circuit diagram has a
block that replaces some components (eg, filter, or signal conditioning, or control circuit), is is a schematic?)
]
Maybe I should review definitions, though I find the terminology people use is inconsistent, but each may be defined in each case (or company, or paper/article, etc).
But it's usually trivial as readers - we usually see what a diagram conveys - or tries to convey! - without caring what its "diagrammatic type" is called.
But one tip - before any test or exam, determine what the
examiners mean... Why didn't I supply a wiring diagram when they asked for a circuit diagram? (Answer - because they asked for a wiring diagram and I was unaware of their definition - not that they had one! $%#@##!!)
Ooops - I digressed.
The underlying point - don't get too confused or hung up on ay issue. "Accept" and file it away for now and later it may (and probably will) fall in place.
And
always be open to new or alternative interpretations (even your own established "facts" or methods). We are clever enough to adapt, and others are clever enough to have better or alternate and still valid solutions.
Oh the pain! (LOL!)
Back to your diagram...
The "input" fed off the LED supply. Shouldn't that be from the brake or tail signal?
If so, or could be combined into the other input's resistive divider - ie, 3 resistors.
As to resistor values, I'll look at that later. We want to determine 4 states - both off (easy - 0V), tail on, brake on, and both on.
Note that for each, we program in a tolerance, eg, 0V is <0.5V, 3V = (say) 2.6V to 3.4V etc.
Also no capacitors
in series with the voltage regulator (caps do not pass DC, hence no current with flow).
They go "across" the supply, ie, between +ve and GND. That's to smoothen the voltage (by "shunting" or conducting the noise (AC) to GND).
FYI - find some good "water models" for electricity. A capacitor is like a a pipe pouring into a bucket with its outlet part way up the side. Once filled above the outlet, the varying water inlet is "smoothed" out at the output.
BTW - don't take water models nor any
model to the extreme. They are merely models chosen to explain certain behavior thru analogy. They do not apply universally - ie, water is not electricity and a bucket is not a cap, but that bucket model is good to picture "capacitor smoothing" in principle.
Too many people take the model to be the real "target" thing. Eg - if you use the atom as a solar system model, you can be in big trouble for certain theories etc.
And models change. Eg - light. Once modelled as particles (eg, ping pong balls). Later modelled as waves. Now modeled as "photons" - a "particle" that exhibits "wave-like" properties. [Ain't that interesting? Do we model electro-magnetism as photons? Light is part of the electro-magnetic band. And if you really want to fuse (bad pun) your mind - what is electricity?; what is its fundumental unit? - it must exist, WE know that! PS - I suggest you might "take this onboard", but DO NOT ponder hard on it - maybe ask the experts and see how they
also squirm!]
Oh dear, lots of digression... [ My
[bracketed] and FYI and BTW etc test tends to be extra info. ]
But apart from series capacitors and that 2nd input, - oh, and a GND for the 78L05 - your circuit, er, schem... er, diagram looks fine. (IMO it's a circuit diagram.)
Input resistance values later, though the others like 150R series LED resistors, and the MOSFET resistors look fine.
Well done!